On Thu, Nov 4, 2021 at 2:20 AM Michael Ellerman <m...@ellerman.id.au> wrote: > Konstantin Ryabitsev <konstan...@linuxfoundation.org> writes: > > On Wed, Nov 03, 2021 at 10:18:57AM +1100, Michael Ellerman wrote: > >> It's not in next, that notification is from the b4 thanks script, which > >> didn't notice that the commit has since been reverted. > > > > Yeah... I'm not sure how to catch that, but I'm open to suggestions. > > I think that's probably the first time I've had a commit and a revert of > the commit in the same batch of thanks mails. > > And the notification is not wrong, the commit was applied with that SHA, > it is in the tree. > > So I'm not sure it's very common to have a commit & a revert in the tree > at the same time.
I know it is not common for the SELinux and audit trees. I guess every tree/maintainer is different, but I'm probably more conservative than most when it comes to merging patches so it's pretty rare that we need to revert things in those trees. > On the other hand being able to generate a mail for an arbitrary revert > would be helpful, ie. independent of any thanks state. > > eg, picking a random commit from the past: > > e95ad5f21693 ("powerpc/head_check: Fix shellcheck errors") > > If I revert that in my tree today, it'd be cool if I could run something > that would detect the revert, backtrack to the reverted commit, extract > the message-id from the Link: tag, and generate a reply to the original > submission noting that it's now been reverted. Even if it isn't practical to do the find-the-original-commit logic, simply getting an email that says "FYI, this revert has been merged into this tree/branch" would be helpful. Although I guess that would require either the revert having the right metadata, e.g. "Cc:", or that prior mentioned logic to find the original commit so the proper To/CC lines could be generated. -- paul moore www.paul-moore.com