Heiko Schocher wrote:
+       [EMAIL PROTECTED] {
+               compatible = "fsl,pq1-localbus";

"fsl,mpc852-localbus", "fsl,pq1-localbus", "simple-bus";

+       [EMAIL PROTECTED] {
+               compatible = "fsl,mpc852", "simple-bus", "fsl,pq1-soc";

simple-bus should come last, since it's the most generic.

+               #address-cells = <1>;
+               #size-cells = <1>;
+               device_type = "soc";
+               ranges = <0 0xfff00000 0x00004000>;
+
+               PIC: [EMAIL PROTECTED] {
+                       interrupt-controller;
+                       #interrupt-cells = <2>;
+                       reg = <0 24>;
+                       compatible = "fsl,pq1-pic";

"fsl,mpc852-pic", "fsl,pq1-pic";

In general, a chip-specific name should be listed first, so the driver can easily apply workarounds if needed. See the existing 8xx device trees for examples.

-Scott

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to