Hi Christophe, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on next-20210701] [cannot apply to v5.13] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-ptdump-Use-DEFINE_SHOW_ATTRIBUTE/20210705-155111 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/58054326bff639a0d69e92d64a9a7321f2756954 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christophe-Leroy/powerpc-ptdump-Use-DEFINE_SHOW_ATTRIBUTE/20210705-155111 git checkout 58054326bff639a0d69e92d64a9a7321f2756954 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): arch/powerpc/mm/ptdump/ptdump.c: In function 'ptdump_show': >> arch/powerpc/mm/ptdump/ptdump.c:311:18: error: 'st.ptdump.range' is a >> pointer; did you mean to use '->'? 311 | st.ptdump.range.start = KERN_VIRT_START; | ^ | -> arch/powerpc/mm/ptdump/ptdump.c:313:18: error: 'st.ptdump.range' is a pointer; did you mean to use '->'? 313 | st.ptdump.range.start = PAGE_OFFSET; | ^ | -> vim +311 arch/powerpc/mm/ptdump/ptdump.c 293 294 static int ptdump_show(struct seq_file *m, void *v) 295 { 296 struct pg_state st = { 297 .seq = m, 298 .marker = address_markers, 299 .level = -1, 300 .ptdump = { 301 .note_page = note_page, 302 .range = (struct ptdump_range[]){ 303 {TASK_SIZE, ~0UL}, 304 {0, 0} 305 } 306 } 307 }; 308 309 #ifdef CONFIG_PPC64 310 if (!radix_enabled()) > 311 st.ptdump.range.start = KERN_VIRT_START; 312 else 313 st.ptdump.range.start = PAGE_OFFSET; 314 #endif 315 316 /* Traverse kernel page tables */ 317 ptdump_walk_pgd(&st.ptdump, &init_mm, NULL); 318 return 0; 319 } 320 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip