On Tue, 2008-06-10 at 10:30 +1000, Michael Ellerman wrote: > On Tue, 2008-06-10 at 09:41 +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2008-06-09 at 16:26 -0700, [EMAIL PROTECTED] wrote: > > > From: Carl Love <[EMAIL PROTECTED]> > > > > > > Fix the 64 bit user code backtrace which currently may hang the system. > > > > > > Signed-off-by: Carl Love <[EMAIL PROTECTED]> > > > Cc: Maynard Johnson <[EMAIL PROTECTED]> > > > > That looks weird. I doubt it's the right fix for the problem. Paul, > > I remember this was discussed earlier, did we come up with a proper fix > > already ? > > We decided there probably wasn't a bug there at all: > > http://ozlabs.org/pipermail/linuxppc-dev/2008-May/056449.html > > Haven't heard from Carl if he reproduced the hang and traced it to > something else. > > cheers >
After a discussion of this patch, the general consensus was that the issue is with the underlying copy from user call. After developing and posting the patch, I had tried to go back and reproduce it again and was not able to. My system had changed slightly and I could get it to fail. I still have this on my to do list to get back to working on the Powerpc callgraph support as there are some other fundamental issues with the code. Specifically the call back traces are not always correct for leaf nodes. This was actually the issue I was working on when I found the issue with the 64 bit applications hanging the system. The patch should be dropped. Carl Love _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev