Michael Ellerman <m...@ellerman.id.au> writes: > Nathan Lynch <nath...@linux.ibm.com> writes: >> post_mobility_fixup() does cpus_read_unlock() before calling >> pseries_setup_security_mitigations(), I think that will need to be >> changed? > > I don't think so. > > I'm using stop_machine_cpuslocked() but that's because I'm a goose and > forgot to switch to stop_machine() after I reworked the code to not take > cpus_read_lock() by hand. I really shouldn't send patches after 11pm. > > I don't think it's important to keep the cpus lock held from where we > take it in post_mobility_fixup(). If some CPUs come or go between there > and here that's fine.
Yes, agreed.
