Hi Nicholas, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on linus/master next-20210430] [cannot apply to scottwood/next v5.12] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-radix-Enable-huge-vmalloc-mappings/20210502-190249 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-akebono_defconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/897024543f33f779ce158849e73999b9d1271f57 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicholas-Piggin/powerpc-64s-radix-Enable-huge-vmalloc-mappings/20210502-190249 git checkout 897024543f33f779ce158849e73999b9d1271f57 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): arch/powerpc/kernel/module.c: In function '__module_alloc': arch/powerpc/kernel/module.c:101:32: error: 'VM_NO_HUGE_VMAP' undeclared (first use in this function) 101 | VM_FLUSH_RESET_PERMS | VM_NO_HUGE_VMAP, | ^~~~~~~~~~~~~~~ arch/powerpc/kernel/module.c:101:32: note: each undeclared identifier is reported only once for each function it appears in In file included from <command-line>: arch/powerpc/kernel/module.c: In function 'module_alloc': >> arch/powerpc/kernel/module.c:111:27: error: 'MODULES_VADDR' undeclared >> (first use in this function) 111 | BUILD_BUG_ON(TASK_SIZE > MODULES_VADDR); | ^~~~~~~~~~~~~ include/linux/compiler_types.h:300:9: note: in definition of macro '__compiletime_assert' 300 | if (!(condition)) \ | ^~~~~~~~~ include/linux/compiler_types.h:320:2: note: in expansion of macro '_compiletime_assert' 320 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ arch/powerpc/kernel/module.c:111:2: note: in expansion of macro 'BUILD_BUG_ON' 111 | BUILD_BUG_ON(TASK_SIZE > MODULES_VADDR); | ^~~~~~~~~~~~ >> arch/powerpc/kernel/module.c:114:37: error: 'MODULES_END' undeclared (first >> use in this function) 114 | if (MODULES_VADDR < PAGE_OFFSET && MODULES_END > limit) | ^~~~~~~~~~~ vim +/MODULES_VADDR +111 arch/powerpc/kernel/module.c 2ec13df167040c Christophe Leroy 2021-04-01 104 7fbc22ce299316 Christophe Leroy 2020-06-29 105 void *module_alloc(unsigned long size) 7fbc22ce299316 Christophe Leroy 2020-06-29 106 { 897024543f33f7 Nicholas Piggin 2021-05-02 107 #ifdef CONFIG_PPC32 2ec13df167040c Christophe Leroy 2021-04-01 108 unsigned long limit = (unsigned long)_etext - SZ_32M; 2ec13df167040c Christophe Leroy 2021-04-01 109 void *ptr = NULL; 2ec13df167040c Christophe Leroy 2021-04-01 110 7fbc22ce299316 Christophe Leroy 2020-06-29 @111 BUILD_BUG_ON(TASK_SIZE > MODULES_VADDR); 7fbc22ce299316 Christophe Leroy 2020-06-29 112 2ec13df167040c Christophe Leroy 2021-04-01 113 /* First try within 32M limit from _etext to avoid branch trampolines */ 2ec13df167040c Christophe Leroy 2021-04-01 @114 if (MODULES_VADDR < PAGE_OFFSET && MODULES_END > limit) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
