On Wed, 21 Apr 2021 22:54:01 +1000, Michael Ellerman wrote: > Sparse says: > arch/powerpc/kernel/fadump.c:48:16: warning: symbol 'fadump_kobj' was not > declared. Should it be static? > arch/powerpc/kernel/fadump.c:55:27: warning: symbol 'crash_mrange_info' was > not declared. Should it be static? > arch/powerpc/kernel/fadump.c:61:27: warning: symbol 'reserved_mrange_info' > was not declared. Should it be static? > arch/powerpc/kernel/fadump.c:83:12: warning: symbol 'fadump_cma_init' was > not declared. Should it be static? > > And indeed none of them are used outside this file, they can all be made > static. Also fadump_kobj needs to be moved inside the ifdef where it's > used.
Applied to powerpc/next. [1/2] powerpc/fadump: Fix sparse warnings https://git.kernel.org/powerpc/c/2e341f56a16a71f240c87ec69711aad0d95a704c [2/2] powerpc/powernv: Fix type of opal_mpipl_query_tag() addr argument https://git.kernel.org/powerpc/c/d936f8182e1bd18f5e9e6c5e8d8b69261200ca96 cheers