On Mon, 2 Jun 2008, Adrian Bunk wrote: > On Mon, Jun 02, 2008 at 11:25:14AM -0500, Kumar Gala wrote: > > > > On Jun 2, 2008, at 11:03 AM, Jeff Garzik wrote: > > > >> Kumar Gala wrote: > >>> The core portions of the phylib aren't capable of being used as > >>> a module. This isn't really any different than something like i2c > >>> in that the bus driver and core need to be built into the kernel. > >>> Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > >>> --- > >>> Jeff, please consider this for 2.6.26 as w/o it we get build issues > >>> if phylib is config'd as a module on ppc. > >>> drivers/net/phy/Kconfig | 2 +- > >>> 1 files changed, 1 insertions(+), 1 deletions(-) > >>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > >>> index 6eb2d31..ab04cc7 100644 > >>> --- a/drivers/net/phy/Kconfig > >>> +++ b/drivers/net/phy/Kconfig > >>> @@ -3,7 +3,7 @@ > >>> # > >>> menuconfig PHYLIB > >>> - tristate "PHY Device support and infrastructure" > >>> + bool "PHY Device support and infrastructure" > >>> depends on !S390 > >>> depends on NET_ETHERNET > >> > >> What are the issues? > >> > >> The core _should_ be able to be built as a module. > > > > The core provides functions like phy_read/phy_write. Andy has recently > > introduced board level workaround/fixups. The problem is these > > workarounds tend to use phy_read/phy_write and the board/platform code is > > not built as modules. > > > > So we get errors like: > > > > arch/powerpc/platforms/built-in.o: In function `mpc8568_mds_phy_fixups': > > /home/galak/git/master/powerpc/arch/powerpc/platforms/85xx/ > > mpc85xx_mds.c:99: undefined reference to `phy_write' > >... > > At first glance PHYLIB=n might also cause similar problems. > > Please send me the failing .config and I'll cook up a fix. > > > - k > > cu > Adrian
defconfig attached. I think Scott might be right in that the simple fix would be to select PHYLIB from the MPC8568_MDS config in arch/powerpc/platforms/85xx/Kconfig. - k
phylib-module.config.gz
Description: GNU Zip compressed data
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
