Hi Anton, On Fri, 23 May 2008 22:28:42 +0400 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > +++ b/drivers/mmc/host/of_mmc_spi.c
> +static int of_mmc_spi_probe(struct spi_device *spi)
> + /*
> + * mmc_spi_probe will use drvdata, so we can't use it. Use node's
> + * data instead.
> + */
> + spi->dev.archdata.of_node->data = oms;
If you delay this assignment, you may not have to clean it up in the
error path.
> + ocr_mask = of_get_property(np, "linux,mmc-ocr-mask", &size);
You should really explicitly include linux/of.h to use of_get_property etc
> +int __devexit of_mmc_spi_remove(struct spi_device *spi)
> +{
> + struct of_mmc_spi *oms = spi->dev.archdata.of_node->data;
> + int ret;
> +
> + ret = mmc_spi_remove(spi);
> + if (ret)
> + return ret;
Maybe you should do this last so that you don't leak more than necessary
if mmc_spi_remove fails. (I don't know what state mmc_spi_remove leaves
stuff in if it fails ...)
> +static struct spi_driver of_mmc_spi_driver = {
> + .driver = {
> + .name = "of_mmc_spi",
> + .bus = &spi_bus_type,
This is initialised by spi_register_driver().
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgppqVuEFurm6.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
