On Tue, Feb 02, 2021 at 03:07:51PM +0100, Miroslav Benes wrote:
> >     preempt_disable();
> > -   sym = find_symbol(symbol, &owner, NULL, NULL, true, true);
> > -   if (sym && strong_try_module_get(owner))
> > -           sym = NULL;
> > +   if (!find_symbol(&fsa) || !strong_try_module_get(fsa.owner)) {
> 
> I think this should be in fact
> 
>   if (!find_symbol(&fsa) || strong_try_module_get(fsa.owner)) {
> 
> to get the logic right (note the missing !). We want to return NULL if 
> strong_try_module_get() does not succeed for a found symbol.

Indeed. Fixed for the next version.

Reply via email to