Le 21/12/2020 à 08:42, Cédric Le Goater a écrit :
It fixes this W=1 compile error:

Explain why it can be made static, not just that it does fix a W=1 compile 
error,
because there are several possible ways to fix such a warning.



../arch/powerpc/platforms/pseries/ras.c:125:12: error: no previous prototype 
for ‘init_ras_hotplug_IRQ’ [-Werror=missing-prototypes]
   125 | int __init init_ras_hotplug_IRQ(void)
       |            ^~~~~~~~~~~~~~~~~~~~

Fixes: c9dccf1d074a ("powerpc/pseries: Enable RAS hotplug events later")
Cc: Mahesh Salgaonkar <mah...@linux.ibm.com>
Cc: Ganesh Goudar <ganes...@linux.ibm.com>
Signed-off-by: Cédric Le Goater <c...@kaod.org>
---
  arch/powerpc/platforms/pseries/ras.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/ras.c 
b/arch/powerpc/platforms/pseries/ras.c
index e27310fc1481..de0a1747cbd1 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -122,7 +122,7 @@ static inline u8 rtas_mc_error_sub_type(const struct 
pseries_mc_errorlog *mlog)
   * devices or systems (e.g. hugepages) that have not been initialized at the
   * subsys stage.
   */
-int __init init_ras_hotplug_IRQ(void)
+static int __init init_ras_hotplug_IRQ(void)
  {
        struct device_node *np;

Reply via email to