On May 19, 2008, at 9:26 PM, Jin Zhengxiong wrote:
-----Original Message-----
From: Michael Ellerman [mailto:[EMAIL PROTECTED]
Sent: Monday, May 19, 2008 10:09 AM
To: Jin Zhengxiong
Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org;
[EMAIL PROTECTED]
Subject: Re: [PATCH 2/4 V5] MSI support on 83xx/85xx/86xx board
On Fri, 2008-05-16 at 17:50 +0800, Jason Jin wrote:
This MSI driver can be used on 83xx/85xx/86xx board.
In this driver, virtual interrupt host and chip were setup.
There are
256 MSI interrupts in this host, Every 32 MSI interrupts
cascaded to
one IPIC/MPIC interrupt.
The chip was treated as edge sensitive and some necessary functions
were setup for this chip.
Before using the MSI interrupt, PCI/PCIE device need to ask
for a MSI
interrupt in the 256 MSI interrupts. A 256bit bitmap show which MSI
interrupt was used, reserve bit in the bitmap can be used
to force the
device use some designate MSI interrupt in the 256 MSI interrupts.
Sometimes this is useful for testing the all the MSI
interrupts. The
msi-available-ranges property in the dts file was used for this
purpose.
Signed-off-by: Jason Jin <[EMAIL PROTECTED]>
---
In the V5 version:
Make the msi-availble-ranges optional, remove the match
function from
the driver, change the compatible according the change in dts.
Looks good, MSI bits:
Acked-by: Michael Ellerman <[EMAIL PROTECTED]>
cheers
Thanks, Michael.
Kumar, Could you please apply the MSI related patches. Thanks
See my comments about the compatible. Once those changes are made
I'll apply these patches.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
