On 9/11/20 7:26 AM, Christophe Leroy wrote: > > > Le 10/09/2020 à 23:02, Cédric Le Goater a écrit : >> arch/powerpc/kernel/sysfs.c: In function ‘sysfs_create_dscr_default’: >> arch/powerpc/kernel/sysfs.c:228:7: error: variable ‘err’ set but not used >> [-Werror=unused-but-set-variable] >> int err = 0; >> ^~~ >> cc1: all warnings being treated as errors > > A small sentence explaining how this is fixes would be welcome, so that you > don't need to read the code the know what the commit does to fix the warning. > Even the subject should be more explicite, rather than saying "Fix W=1 > compile warning", I think it should say something like "remove unused err > variable"
Yes. I will respin a v2 with better commit logs for all. Thanks, C.
