On Wed, 15 Jul 2020, Viresh Kumar wrote: > On 14-07-20, 22:23, Wei Yongjun wrote: > > The sparse tool complains as follows: > > > > drivers/cpufreq/powernv-cpufreq.c:88:1: warning: > > symbol 'pstate_revmap' was not declared. Should it be static? > > drivers/cpufreq/powernv-cpufreq.c:383:18: warning: > > symbol 'cpufreq_freq_attr_cpuinfo_nominal_freq' was not declared. Should > > it be static? > > drivers/cpufreq/powernv-cpufreq.c:669:6: warning: > > symbol 'gpstate_timer_handler' was not declared. Should it be static? > > drivers/cpufreq/powernv-cpufreq.c:902:6: warning: > > symbol 'powernv_cpufreq_work_fn' was not declared. Should it be static? > > > > Those symbols are not used outside of this file, so mark > > them static. > > > > Reported-by: Hulk Robot <hul...@huawei.com> > > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> > > --- > > drivers/cpufreq/powernv-cpufreq.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > Lee also sent a fix for this, but yours look complete :) > > https://lore.kernel.org/lkml/20200714145049.2496163-7-lee.jo...@linaro.org/ > > Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
Yes, looks good to me. Reviewed-by: Lee Jones <lee.jo...@linaro.org> -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
