Christophe Leroy <christophe.le...@csgroup.eu> writes: > Le 25/05/2020 à 07:15, Michael Ellerman a écrit : >> Christophe Leroy <christophe.le...@csgroup.eu> writes: >>> In order to have all flags fit on a 80 chars wide screen, >>> reduce the flags to 1 char (2 where ambiguous). >> >> I don't love this, the output is less readable. Is fitting on an 80 char >> screen a real issue for you? I just make my terminal window bigger. > > I don't have strong opinion about that, and the terminal can be made bigger. > I just don't like how messy it is, some flags are so big that they hide > other ones and getting it more ordered and more compact helped me during > all the verifications I did with this series, but we can leave it as is > if you prefer.
I think I do. > Would you like a v5 without patches 7 and 8 ? Or I can just resend the > patches that will be impacted, that is 9 and 38 ? I dropped 7 and 8 and then fixed up 9 and 38, it was easy enough. I used "coherent" and "huge". > With the change I get. > > ---[ Start of kernel VM ]--- > 0xc0000000-0xc0ffffff 0x00000000 16M h r x p sh a > 0xc1000000-0xc7ffffff 0x01000000 112M h rw p sh d a > ---[ vmalloc() Area ]--- > 0xc9000000-0xc9003fff 0x050e4000 16K rw p sh d a > 0xc9008000-0xc900bfff 0x050ec000 16K rw p sh d a > 0xc9010000-0xc9013fff 0xd0000000 16K rw p i g sh d a > 0xc9018000-0xc901bfff 0x050f0000 16K rw p sh d a It's definitely more compact :) But I worry no one other than you will be able to decipher it, without constantly referring back to the source code. cheers
