Le 19/05/2020 à 06:05, Michael Ellerman a écrit :
Jordan Niethe <jniet...@gmail.com> writes:
On Sun, May 17, 2020 at 4:39 AM Christophe Leroy
<christophe.le...@csgroup.eu> wrote:

Le 06/05/2020 à 05:40, Jordan Niethe a écrit :
Prefixed instructions will mean there are instructions of different
length. As a result dereferencing a pointer to an instruction will not
necessarily give the desired result. Introduce a function for reading
instructions from memory into the instruction data type.


Shouldn't this function be used in mmu_patch_addis() in mm/nohash/8xx.c ?

Christophe

Yes, that would be a good idea.

mpe here is a fix, along with one I'll
post for [PATCH v8 11/30] powerpc: Use a datatype for instructions.

I didn't fold this in because I'd prefer one of you send me a patch on
top of the series that converts that code to use the new type.

That way it can be tested separately from this big series.


All this code is going away with the series implementing the use of hugepages for kernel mappings on 8xx (https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=176094) that I hope will go in 5.8, so there is no point in sending a patch to change that I guess.

Is there anything special I need to do to secure the merging of that series in 5.8 ?

Christophe

Reply via email to