For what it's worth: Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]>
There's one or two other things I've been meaning to clean up, such as the section mismatch on hwicap_of_match, too. Steve > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:linuxppc-dev- > [EMAIL PROTECTED] On Behalf Of Kumar Gala > Sent: Wednesday, April 30, 2008 8:26 AM > To: Josh Boyer > Cc: linuxppc-dev@ozlabs.org > Subject: [PATCH] [POWERPC] Xilinx: Fix compile warnings > > arch/powerpc/sysdev/xilinx_intc.c: In function ‘xilinx_intc_init’: > arch/powerpc/sysdev/xilinx_intc.c:111: warning: format ‘%08X’ expects > type ‘unsigned int’, > but argument 2 has type ‘resource_size_t’ > drivers/char/xilinx_hwicap/xilinx_hwicap.c: In function ‘hwicap_setup’: > drivers/char/xilinx_hwicap/xilinx_hwicap.c:626: warning: cast to pointer from > integer of different > size > drivers/char/xilinx_hwicap/xilinx_hwicap.c:646: warning: format ‘%x’ > expects type ‘unsigned > int’, but argument 6 has type ‘resource_size_t’ > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/xilinx_intc.c | 2 +- > drivers/char/xilinx_hwicap/xilinx_hwicap.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/sysdev/xilinx_intc.c > b/arch/powerpc/sysdev/xilinx_intc.c > index ba8eea2..b7aefd0 100644 > --- a/arch/powerpc/sysdev/xilinx_intc.c > +++ b/arch/powerpc/sysdev/xilinx_intc.c > @@ -107,7 +107,7 @@ xilinx_intc_init(struct device_node *np) > } > regs = ioremap(res.start, 32); > > - printk(KERN_INFO "Xilinx intc at 0x%08X mapped to 0x%p\n", > + printk(KERN_INFO "Xilinx intc at 0x%08LX mapped to 0x%p\n", > res.start, regs); > > /* Setup interrupt controller */ > diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c > b/drivers/char/xilinx_hwicap/xilinx_hwicap.c > index dfe6907..3edf1fc 100644 > --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c > +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c > @@ -623,8 +623,8 @@ static int __devinit hwicap_setup(struct device *dev, int > id, > > if (!request_mem_region(drvdata->mem_start, > drvdata->mem_size, DRIVER_NAME)) { > - dev_err(dev, "Couldn't lock memory region at %p\n", > - (void *)regs_res->start); > + dev_err(dev, "Couldn't lock memory region at %Lx\n", > + regs_res->start); > retval = -EBUSY; > goto failed1; > } > @@ -643,7 +643,7 @@ static int __devinit hwicap_setup(struct device *dev, int > id, > mutex_init(&drvdata->sem); > drvdata->is_open = 0; > > - dev_info(dev, "ioremap %lx to %p with size %x\n", > + dev_info(dev, "ioremap %lx to %p with size %Lx\n", > (unsigned long int)drvdata->mem_start, > drvdata->base_address, drvdata->mem_size); > > -- > 1.5.4.1 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
