On Tue, Apr 21, 2020 at 11:53 AM Alistair Popple <alist...@popple.id.au> wrote: > > On Tuesday, 21 April 2020 11:30:52 AM AEST Alistair Popple wrote: > > On Saturday, 4 April 2020 2:32:08 AM AEST Segher Boessenkool wrote: > > > Hi! > > > > > > On Fri, Apr 03, 2020 at 03:10:54PM +1100, Alistair Popple wrote: > > > > +#define PCR_ARCH_300 0x10 /* Architecture 3.00 */ > > > > > > It's called 3.0, not 3.00? > > > > Thanks. I'll fix that up. > > Actually we have already defined it upstream as CPU_FTR_ARCH_300 in arch/ > powerpc/include/asm/cputable.h and PVR_ARCH_300 in arch/powerpc/include/asm/ > reg.h so for consistency we should make it the same here. So either we leave > this patch as is or we change it to PCR_ARCH_30 along with the existing > upstream #defines. Thoughts?
I used 300 for consistency with the existing three digit definitions when I added the CPU_FTR macro. It doesn't really matter since these are all internal definitions, but I SAY THE BIKESHED SHOULD BE THREE DIGITS LONG. Oliver
