On Mon, Apr 28, 2008 at 05:40:19PM +0200, Guennadi Liakhovetski wrote:
> +static int ls_pm_enter(suspend_state_t state)
> +{
> + u64 tb;
> +
> + /* Get timebase */
> + tb = get_tb();
> +
> + /* put CPU to sleep, re-enabling interrupts */
> + mpc6xx_enter_standby();
> +
> + local_irq_disable();
Interrupts should not be enabled when you come out of
mpc6xx_enter_standby(); see the TLF_SLEEPING patch.
> +#define MPC10X_LP_REF_EN (1<<12)
> +#define MPC10X_PM (1<<7)
> +#define MPC10X_DOZE (1<<5)
> +#define MPC10X_NAP (1<<4)
> +#define MPC10X_SLEEP (1<<3)
Mismatched whitespace (MPC10X_DOZE has a space before it; the others have
tabs).
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
