On Tue, Apr 14, 2020 at 02:42:56PM +0200, Emanuele Giuseppe Esposito wrote: > We will augment this family of functions with inode management. To avoid > littering include/linux/fs.h and fs/libfs.c, move them to a separate header, > with a Kconfig symbol to enable them. > > Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
You have a lot of people on cc:, this is going to be hard for everyone to review... > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d1398cef3b18..fc38a6f0fc11 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -288,12 +288,16 @@ config STRIP_ASM_SYMS > > config READABLE_ASM > bool "Generate readable assembler code" > - depends on DEBUG_KERNEL > - help > - Disable some compiler optimizations that tend to generate human > unreadable > - assembler output. This may make the kernel slightly slower, but it > helps > - to keep kernel developers who have to stare a lot at assembler > listings > - sane. > + depends on DEBUG_KERNEL > + help > + Disable some compiler optimizations that tend to generate human > unreadable > + assembler output. This may make the kernel slightly slower, but it > helps > + to keep kernel developers who have to stare a lot at assembler listings > + sane. > + Why did you loose the indentation here and add trailing whitespace? > +config DEBUG_FS > + bool "Debug Filesystem" > + select SIMPLEFS > We already have a DEBUG_FS config option in this file, why another one? And what happened to the help text? I think you need to rework your patch series to do smaller things on each step, which would make it reviewable much easier, and prevent mistakes like this one. thanks, greg k-h
