Here needs a NULL check, as kzalloc may fail returning NULL. Issue was found by coccinelle. Generated by: scripts/coccinelle/null/kmerr.cocci
Signed-off-by: Qiujun Huang <hqjag...@gmail.com> Reviewed-by: Oliver O'Halloran <ooh...@gmail.com> --- arch/powerpc/platforms/powernv/opal.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 71af1cbc6334..908d749bcef5 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -811,6 +811,9 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name, return rc; attr = kzalloc(sizeof(*attr), GFP_KERNEL); + if (!attr) + return -ENOMEM; + name = kstrdup(export_name, GFP_KERNEL); if (!name) { rc = -ENOMEM; -- 2.17.1