Nicholas Piggin's on April 3, 2020 7:35 pm: > Signed-off-by: Nicholas Piggin <npig...@gmail.com>
Sorry that was a bad rebase, here's the fixed patch. --- arch/powerpc/include/asm/uaccess.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h index 144d01645d68..8a0474682c9b 100644 --- a/arch/powerpc/include/asm/uaccess.h +++ b/arch/powerpc/include/asm/uaccess.h @@ -48,16 +48,16 @@ static inline void set_fs(mm_segment_t fs) * gap between user addresses and the kernel addresses */ #define __access_ok(addr, size, segment) \ - (((addr) <= (segment).seg) && ((size) <= (segment).seg)) + likely(((addr) <= (segment).seg) && ((size) <= (segment).seg)) #else static inline int __access_ok(unsigned long addr, unsigned long size, mm_segment_t seg) { - if (addr > seg.seg) + if (unlikely(addr > seg.seg)) return 0; - return (size == 0 || size - 1 <= seg.seg - addr); + return likely(size == 0 || size - 1 <= seg.seg - addr); } #endif @@ -177,7 +177,7 @@ do { \ else \ __put_user_size_allowed(__pu_val, __pu_addr, __pu_size, __pu_err); \ \ - __pu_err; \ + __builtin_expect(__pu_err, 0); \ }) #define __put_user_check(x, ptr, size) \ @@ -191,7 +191,7 @@ do { \ if (access_ok(__pu_addr, __pu_size)) \ __put_user_size(__pu_val, __pu_addr, __pu_size, __pu_err); \ \ - __pu_err; \ + __builtin_expect(__pu_err, 0); \ }) #define __put_user_nosleep(x, ptr, size) \ @@ -204,7 +204,7 @@ do { \ __chk_user_ptr(__pu_addr); \ __put_user_size(__pu_val, __pu_addr, __pu_size, __pu_err); \ \ - __pu_err; \ + __builtin_expect(__pu_err, 0); \ }) @@ -307,7 +307,7 @@ do { \ __get_user_size_allowed(__gu_val, __gu_addr, __gu_size, __gu_err); \ (x) = (__typeof__(*(ptr)))__gu_val; \ \ - __gu_err; \ + __builtin_expect(__gu_err, 0); \ }) #define __get_user_check(x, ptr, size) \ @@ -324,7 +324,7 @@ do { \ } \ (x) = (__force __typeof__(*(ptr)))__gu_val; \ \ - __gu_err; \ + __builtin_expect(__gu_err, 0); \ }) #define __get_user_nosleep(x, ptr, size) \ @@ -339,7 +339,7 @@ do { \ __get_user_size(__gu_val, __gu_addr, __gu_size, __gu_err); \ (x) = (__force __typeof__(*(ptr)))__gu_val; \ \ - __gu_err; \ + __builtin_expect(__gu_err, 0); \ }) -- 2.23.0