Thomas Gleixner <t...@linutronix.de> writes: > From: Thomas Gleixner <t...@linutronix.de> > > The completion usage in this driver is interesting: > > - it uses a magic complete function which according to the comment was > implemented by invoking complete() four times in a row because > complete_all() was not exported at that time. > > - it uses an open coded wait/poll which checks completion:done. Only one > wait > side (device removal) uses the regular wait_for_completion() interface. > > The rationale behind this is to prevent that wait_for_completion() consumes > completion::done which would prevent that all waiters are woken. This is not > necessary with complete_all() as that sets completion::done to UINT_MAX which > is left unmodified by the woken waiters. > > Replace the magic complete function with complete_all() and convert the > open coded wait/poll to regular completion interfaces. > > This changes the wait to exclusive wait mode. But that does not make any > difference because the wakers use complete_all() which ignores the > exclusive mode. > > Reported-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Kalle Valo <kv...@codeaurora.org> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: linux-wirel...@vger.kernel.org > Cc: net...@vger.kernel.org > Cc: linux-...@vger.kernel.org > --- > V2: New patch to avoid conversion to swait functions later. > --- > drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 21 > ++++---------------- > 1 file changed, 5 insertions(+), 16 deletions(-)
I assume this is going via some other than wireless-drivers so: Acked-by: Kalle Valo <kv...@codeaurora.org> -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
