On Wed, Mar 18, 2020 at 12:44:52PM +0100, Christophe Leroy wrote: > Le 18/03/2020 à 12:35, Michael Ellerman a écrit : > >Christophe Leroy <christophe.le...@c-s.fr> writes: > >>Le 09/03/2020 à 09:58, Ravi Bangoria a écrit : > >>>Currently we assume that we have only one watchpoint supported by hw. > >>>Get rid of that assumption and use dynamic loop instead. This should > >>>make supporting more watchpoints very easy. > >> > >>I think using 'we' is to be avoided in commit message. > > > >Hmm, is it? > > > >I use 'we' all the time. Which doesn't mean it's correct, but I think it > >reads OK. > > > >cheers > > From > https://www.kernel.org/doc/html/latest/process/submitting-patches.html : > > Describe your changes in imperative mood, e.g. “make xyzzy do frotz” > instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy > to do frotz”, as if you are giving orders to the codebase to change its > behaviour.
That is what is there already? "Get rid of ...". You cannot describe the current situation with an imperative. Segher
