On Thu, Feb 6, 2020 at 3:13 PM Sam Bobroff <sbobr...@linux.ibm.com> wrote: > > On Mon, Feb 03, 2020 at 07:35:16PM +1100, Oliver O'Halloran wrote: > > Move creating the EEH specific sysfs files into eeh_add_device_late() > > rather than being open-coded all over the place. Calling the function is > > generally done immediately after calling eeh_add_device_late() anyway. The > > two cases where it's not done there (OF based PCI probing and the pseries > > VFs) don't seem to have any issues with the re-ordering. > > I haven't tested it explicitly, but I suspect the re-ordering will > actually improve things: in some error cases it will no longer add sysfs > files for devices that have failed to init, because bailing out in > eeh_add_device_late() (or eeh_probve_device()) will now prevent > eeh_sysfs_add_device() from being called. > > Nice cleanup. > > Reviewed-by: Sam Bobroff <sbobr...@linux.ibm.com>
Ah, good point. I'll update the commit message.
