On Wed, Apr 16, 2008 at 11:41:08PM -0700, Grant Likely wrote: > On Wed, Apr 16, 2008 at 11:00 PM, Robert Schwebel > <[EMAIL PROTECTED]> wrote: > > On Tue, Apr 15, 2008 at 05:29:54PM +0200, Robert Schwebel wrote: > > > From: Sascha Hauer <[EMAIL PROTECTED]> > > > > > > Add a set_type function for external (GPIO) interrupts. > > > > > > Signed-off-by: Juergen Beisert <[EMAIL PROTECTED]> > > > Signed-off-by: Sascha Hauer <[EMAIL PROTECTED]> > > > > As we didn't get negative feedback yet, could this go into the 2.6.26 > > merge window? > > I didn't see this the first time (didn't get cc'd). > > It looks mostly okay, but in doesn't have any mutual exclusion which > it probably should have. What are the users of this?
No, it is used in kernel/irq/chip.c and kernel/irq/manage.c. Both callers already hold the mpc52xx_extirq_irqchip.lock spinlock. Sascha -- Pengutronix e.K. - Linux Solutions for Science and Industry ----------------------------------------------------------- Kontakt-Informationen finden Sie im Header dieser Mail oder auf der Webseite -> http://www.pengutronix.de/impressum/ <- _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
