On Thursday 17 April 2008 13:21, Jochen Friedrich wrote: > Hi Laurent, > > >> http://patchwork.ozlabs.org/linuxppc/patch?id=16282 > > > > The link doesn't seem to be related. > > http://patchwork.ozlabs.org/linuxppc/patch?id=17490 is the correct one.
Thanks. > > I'll rework the patch to move CPM2 GPIO support to cpm_common.c. Have you > > thought about a proper name for the compatible property ? > > I would leave cpm_init_par_io() in cpm2.c and just move the other parts. > - for cpm2, the property fsl,cpm2-pario-bank is correct. > - for cpm1, i'm thinking of something like fsl,cpm1-pario-bank32b and fsl,cpm1-pario-bank32e. Any preference for common function names ? cpm2_gpio32* might be too CPM2-specific for cpm_common.c. cpm_gpio32* is a bit too generic as it doesn't support port E on the CPM1. BTW, what's the purpose of the shadow data register in the CPM GPIO chip structure ? As the set operation is protected by a spinlock, the only use I can think of is to prevent changing bits in the PDAT register for pins configured as inputs. Is that correct ? If so this should be clearly documented in the code. -- Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75
pgpWx2ZllGqmC.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
