"Linuxppc-dev" <linuxppc-dev-bounces+hbabu=us.ibm....@lists.ozlabs.org>
wrote on 11/27/2019 12:28:10 AM:
>
> On Tue, Nov 26, 2019 at 05:03:27PM -0800, Haren Myneni wrote:
> >
> > This reverts commit 452d23c0f6bd97f2fd8a9691fee79b76040a0feb.
> >
> > User space send windows (NX GZIP compression) need vas_win_paste_addr()
> > to mmap window paste address and vas_win_id() to get window ID when
> > window address is given.
>
> Even with your full series applied vas_win_paste_addr is entirely
> unused, and vas_win_id is only used once in the same file it is defined.
Thanks for the review.
vas_win_paste_addr() will be used in NX compression driver and planning to
post this series soon. Can I add this change later as part of this series?
>
> So instead of this patch you should just open code vas_win_id in
> init_winctx_for_txwin.
>
> > +static inline u32 encode_pswid(int vasid, int winid)
> > +{
> > + u32 pswid = 0;
> > +
> > + pswid |= vasid << (31 - 7);
> > + pswid |= winid;
> > +
> > + return pswid;
>
> This can be simplified down to:
>
> return (u32)winid | (vasid << (31 - 7));
>
