On Thu, Nov 21, 2019 at 3:02 PM Alexey Kardashevskiy <a...@ozlabs.ru> wrote: > > > > On 20/11/2019 12:28, Oliver O'Halloran wrote: > > These functions are only used from pci-ioda.c. Move them in there and remove > > the prototypes from the header files. > > > Make them static then, or am I missing the point?
I forgot. > > With that fixed, > > > Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru> > > > > Also, pci-ioda.c is around 4000 lines long, if anything I'd rather be > moving things to a separate new file (pci-ioda-dma.c or whatever). OTOH > after everything you've done, pci-ioda.c is 77 lines shorter so I'll > shut up now :) IMO pci-ioda and pci.c should probably be folded together since there's no clear distinction between the two. We might be able to split off the PCI/NPU/OpenCAPI PHB specific functions into separate files to slim things down a bit, but I still need to re-work some of PHB init code and to make that possible. Oliver
