> -----Original Message----- > From: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Sent: 2019年11月5日 20:33 > To: Xiaowei Bao <xiaowei....@nxp.com> > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo > Li <leoyang...@nxp.com>; M.h. Lian <minghuan.l...@nxp.com>; Mingkai Hu > <mingkai...@nxp.com>; Roy Zang <roy.z...@nxp.com>; > linux-...@vger.kernel.org; devicet...@vger.kernel.org; > linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linuxppc-dev@lists.ozlabs.org; bhelg...@google.com; Z.q. Hou > <zhiqiang....@nxp.com> > Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support > > On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote: > > Add support for the LS1028a PCIe controller. > > > > Signed-off-by: Xiaowei Bao <xiaowei....@nxp.com> > > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > > --- > > v2: > > - No change. > > v3: > > - Reuse the ls2088 driver data structurt. > > v4: > > - No change. > > v5: > > - No change. > > v6: > > - No change. > > > > drivers/pci/controller/dwc/pci-layerscape.c | 1 + > > 1 file changed, 1 insertion(+) > > I have not seen any comment on any layerscape driver patches coming from > the maintainers as listed in the MAINTAINERS file (and CCed in this series). > > I request maintainers ACK on these patches and I expect them to start > reviewing your code if they want to be still considered maintainers for this > driver. > > The changes look OK minus Shawn's remark on compatible string that was > ignored.
Hi Lorenzo, Thanks for your comments. In fact, the patches have reviewed in our internal mail list, after the review by Minghuan and Mingkai, I will send these patches to opensource, they will give the ACK when these patches seems is OK and no comments on this. Thanks Xiaowei > > Thanks, > Lorenzo > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c > > b/drivers/pci/controller/dwc/pci-layerscape.c > > index 3a5fa26..f24f79a 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata > > = { static const struct of_device_id ls_pcie_of_match[] = { > > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata }, > > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata }, > > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata }, > > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata }, > > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata }, > > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata }, > > -- > > 2.9.5 > >