Anton Vorontsov wrote:
On Fri, Apr 11, 2008 at 09:09:57AM -0500, Kumar Gala wrote:
On Mar 11, 2008, at 12:24 PM, Anton Vorontsov wrote:
These will be used by the FSL UPM NAND driver.
can this be a bit more descriptive. What exactly are these functions
trying to accomplish.
Yeah, sorry about that. Here is updated patch, with a bit more descriptive
comment, and highly kernel-doc'ed functions.
+int fsl_upm_find(u32 base, struct fsl_upm *upm)
what is base?
Address base, as in LBC Base address register. Fixed down below.
Should it be phys_addr_t?
+/**
+ * fsl_upm_find - find pre-programmed UPM via base address
+ * @addr_base: base address of the memory bank controlled by the UPM
+ * @upm: pointer to the allocated fsl_upm structure
+ *
+ * This function walks UPMs comparing "Base address" field of the BR registers
+ * with the supplied addr_base argument. When bases are match, this function
+ * fills fsl_upm structure so you can use it with the rest of UPM API. On
+ * success this function returns 0, otherwise it returns appropriate errno
+ * value.
+ */
The FCM driver does something very similar; could we name this something
more generic such as fsl_lbc_find?
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
