Re: [PATCH v6 20/30] powerpc/pci: Fix crash with enabled movable BARs

[Alexey Kardashevskiy]

On 25/10/2019 04:12, Sergey Miroshnichenko wrote:
> Add a check for the UNSET resource flag to skip the released BARs


Where/why does it crash exactly? It is not extremely clear from the code. 
Thanks,

> 
> CC: Alexey Kardashevskiy <a...@ozlabs.ru>
> CC: Oliver O'Halloran <ooh...@gmail.com>
> CC: Sam Bobroff <sbobr...@linux.ibm.com>
> Signed-off-by: Sergey Miroshnichenko <s.miroshniche...@yadro.com>
> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c 
> b/arch/powerpc/platforms/powernv/pci-ioda.c
> index c28d0d9b7ee0..33d5ed8c258f 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -2976,7 +2976,8 @@ static void pnv_ioda_setup_pe_res(struct pnv_ioda_pe 
> *pe,
>       int index;
>       int64_t rc;
>  
> -     if (!res || !res->flags || res->start > res->end)
> +     if (!res || !res->flags || res->start > res->end ||
> +         (res->flags & IORESOURCE_UNSET))
>               return;
>  
>       if (res->flags & IORESOURCE_IO) {
> 

-- 
Alexey