On 17-10-19, 21:41, John Hubbard wrote: > On 10/17/19 9:38 PM, Viresh Kumar wrote: > > On 17-10-19, 21:34, John Hubbard wrote: > >> On 10/17/19 9:27 PM, Viresh Kumar wrote: > >>> On 17-10-19, 17:04, John Hubbard wrote: > >>>> The following build warning occurred on powerpc 64-bit builds: > >>>> > >>>> drivers/cpufreq/powernv-cpufreq.c: In function 'init_chip_info': > >>>> drivers/cpufreq/powernv-cpufreq.c:1070:1: warning: the frame size of > >>>> 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] > >>> > >>> How come we are catching this warning after 4 years ? > >>> > >> > >> Newer compilers. And btw, I don't spend a lot of time in powerpc > >> code, so I just recently ran this, and I guess everyone has been on less > >> new compilers so far, it seems. > >> > >> I used a gcc 8.1 cross compiler in this case: > > > > Hmm, okay. > > > > I hope you haven't missed my actual review comments on your patch, > > just wanted to make sure we don't end up waiting for each other > > indefinitely here :) > > > > Ha, I did overlook those. It's late around here, I guess. :)
Good that I reminded you then :) -- viresh
