On Thu, Apr 10, 2008 at 07:22:17PM -0400, Paul Gortmaker wrote:
> This adds support for the Wind River SBC8641D board, based
> largely on the mpc86xx_hpcn support. The biggest difference is
> the lack of the Uli and the i8259 cascade, which simplifies things.
Hi Paul,
A couple issues. (These should be fixed in the mpc86xx_hpcn.c as well.)
> +void __init
> +sbc8641_init_irq(void)
Make this function static.
> +void
> +sbc8641_show_cpuinfo(struct seq_file *m)
This one too.
> +static int __init sbc8641_probe(void)
> +{
> + unsigned long root = of_get_flat_dt_root();
> +
> + if (of_flat_dt_is_compatible(root, "mpc86xx"))
"mpc86xx" is too generic. You should make the compatible field
in your devtree something like "WIND,sbc8641d", to differentiate
it from the mpc86xx_hpcn.
> +long __init
> +mpc86xx_time_init(void)
Another static function.
Regards,
-Dale
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
