Re: [PATCH v5 05/31] pseries/fadump: introduce callbacks for platform specific operations

[Hari Bathini]

On 03/09/19 9:36 PM, Hari Bathini wrote:
> 
> 
> On 03/09/19 4:40 PM, Michael Ellerman wrote:
>> Hari Bathini <hbath...@linux.ibm.com> writes:
>>> Introduce callback functions for platform specific operations like
>>> register, unregister, invalidate & such. Also, define place-holders
>>> for the same on pSeries platform.
>>
>> We already have an ops structure for machine specific calls, it's
>> ppc_md. Is there a good reason why these aren't just in machdep_calls
>> under #ifdef CONFIG_FA_DUMP ?
> 
> Not really. We move this callbacks to 'struct machdep_calls'

Actually, we can't move this callbacks to 'struct machdep calls' as we need
these callbacks much before machine_probe().

So, if we have to use ppc_md callbacks for fadump... we need to be set the
callbacks twice. Once during dt_scan and again in setup_fadump. Not worth it, I 
guess..

- Hari