> -----Original Message----- > From: Andrew Murray <andrew.mur...@arm.com> > Sent: 2019年9月2日 20:32 > To: Xiaowei Bao <xiaowei....@nxp.com> > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo > Li <leoyang...@nxp.com>; kis...@ti.com; lorenzo.pieral...@arm.com; M.h. > Lian <minghuan.l...@nxp.com>; Mingkai Hu <mingkai...@nxp.com>; Roy > Zang <roy.z...@nxp.com>; jingooh...@gmail.com; > gustavo.pimen...@synopsys.com; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linuxppc-dev@lists.ozlabs.org; > a...@arndb.de; gre...@linuxfoundation.org; Z.q. Hou > <zhiqiang....@nxp.com> > Subject: Re: [PATCH v3 05/11] dt-bindings: pci: layerscape-pci: add compatible > strings for ls1088a and ls2088a > > On Mon, Sep 02, 2019 at 11:17:10AM +0800, Xiaowei Bao wrote: > > Add compatible strings for ls1088a and ls2088a. > > > > Signed-off-by: Xiaowei Bao <xiaowei....@nxp.com> > > --- > > v2: > > - No change. > > v3: > > - Use one valid combination of compatible strings. > > > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > index e20ceaa..762ae41 100644 > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > > @@ -22,7 +22,9 @@ Required properties: > > "fsl,ls1043a-pcie" > > "fsl,ls1012a-pcie" > > EP mode: > > - "fsl,ls1046a-pcie-ep", "fsl,ls-pcie-ep" > > + "fsl,ls1046a-pcie-ep" "fsl,ls-pcie-ep" > > + "fsl,ls1088a-pcie-ep" "fsl,ls-pcie-ep" > > + "fsl,ls2088a-pcie-ep" "fsl,ls-pcie-ep" > > This isn't consistent with "[PATCH v3 09/11] PCI: layerscape: Add EP mode..." > as that patch drops the fallback "fsl,ls-pcie-ep". Either the fallback must be > preserved in the driver, or you need to drop it here. > > What if there are existing users that depend on the fallback? > > (I'm also not sure if that comma should have been dropped).
Hi Andrew, Thanks for your comments, I lose the comma. Thanks Xiaowei > > Thanks, > > Andrew Murray > > > - reg: base addresses and lengths of the PCIe controller register blocks. > > - interrupts: A list of interrupt outputs of the controller. Must contain > > an > > entry for each entry in the interrupt-names property. > > -- > > 2.9.5 > >
