Hi Chris,

> Read-only mode should not prevent listing and clearing any active
> breakpoints.

I tested this and it works for me:

Tested-by: Daniel Axtens <d...@axtens.net>

> +             if (xmon_is_ro || !scanhex(&a)) {

It took me a while to figure out what this line does: as I understand
it, the 'b' command can also be used to install a breakpoint (as well as
bi/bd). If we are in ro mode or if the input after 'b' doesn't scan as a
hex string, print the list of breakpoints instead. Anyway, I'm now
happy with it, so:

Reviewed-by: Daniel Axtens <d...@axtens.net>

Regards,
Daniel

>                       /* print all breakpoints */
>                       printf("   type            address\n");
>                       if (dabr.enabled) {
> -- 
> 2.23.0

Reply via email to