Segher Boessenkool wrote:
>> + [EMAIL PROTECTED] {
>> + label = "fs";
>> + reg = <0x00300000 0x07c00000>;
>> + };
>> + [EMAIL PROTECTED] {
>> + label = "firmware";
>> + reg = <0x07700000 0x00100000>;
>
> These two overlap; should the latter be @7f00000?
Yes, of course.
>
>> + [EMAIL PROTECTED],0 {
>> + device_type = "can";
>
> No device_type please.
OK, but then I better use a more descriptive name for the compatible
property, e.g.:
compatible = "can-i82527"; // Intel 82527 or Bosch CC770
>
>> + [EMAIL PROTECTED],0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "fsl,mpc8560-fcm-nand",
>> + "fsl,elbc-fcm-nand";
>> + reg = <0x3 0x0 0x8000>;
>> +
>> + [EMAIL PROTECTED] {
>> + label = "kernel";
>> + reg = <0x000000 0x0300000>;
>> + };
>> + [EMAIL PROTECTED] {
>> + label = "fs";
>> + reg = <0x300000 0x7d00000>;
>> + };
>> + };
>> + };
>
> There should be a node that describes the nand chip between the nand
> controller node and the partition nodes.
I took the mpc8378_*.dts files of 2.6.25-rc8 as example and there is no
such node. Could you point me please to a more appropriate example.
>
>> Do these entries make sense?
>
> Looks good otherwise :-)
Thanks.
Wolfgang.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
