Hi "Christopher,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc4 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Christopher-M-Riedl/Fix-oops-in-shared-processor-spinlocks/20190806-204502
config: powerpc-powernv_defconfig (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 7.4.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/spinlock.h:89:0,
                    from include/linux/seqlock.h:36,
                    from include/linux/time.h:6,
                    from include/linux/compat.h:10,
                    from arch/powerpc/kernel/asm-offsets.c:14:
   arch/powerpc/include/asm/spinlock.h: In function 'is_shared_processor':
>> arch/powerpc/include/asm/spinlock.h:119:34: error: 'struct paca_struct' has 
>> no member named 'lppaca_ptr'; did you mean 'slb_cache_ptr'?
      lppaca_shared_proc(local_paca->lppaca_ptr));
                                     ^~~~~~~~~~
                                     slb_cache_ptr
   make[2]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   7 real  4 user  3 sys  110.24% cpu   make prepare

vim +119 arch/powerpc/include/asm/spinlock.h

   110  
   111  static inline bool is_shared_processor(void)
   112  {
   113  /*
   114   * LPPACA is only available on BOOK3S so guard anything LPPACA related 
to
   115   * allow other platforms (which include this common header) to compile.
   116   */
   117  #ifdef CONFIG_PPC_BOOK3S
   118          return (IS_ENABLED(CONFIG_PPC_SPLPAR) &&
 > 119                  lppaca_shared_proc(local_paca->lppaca_ptr));
   120  #else
   121          return false;
   122  #endif
   123  }
   124  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to