On Tue, 6 Aug 2019 11:23:08 -0500, Thomas Falcon wrote: > Reported ethtool link settings for the ibmveth driver are currently > hardcoded and no longer reflect the actual capabilities of supported > hardware. There is no interface designed for retrieving this information > from device firmware nor is there any way to update current settings > to reflect observed or expected link speeds. > > To avoid breaking existing configurations, retain current values as > default settings but let users update them to match the expected > capabilities of underlying hardware if needed. This update would > allow the use of configurations that rely on certain link speed > settings, such as LACP. This patch is based on the implementation > in virtio_net. > > Signed-off-by: Thomas Falcon <tlfal...@linux.ibm.com>
Looks like this is the third copy of the same code virtio and netvsc have :( Is there a chance we could factor this out into helpers in the core?