On Thu, 2008-04-03 at 23:09 +0400, Valentine Barshak wrote:
> We really need to ack interrupts at mpic_teardown, since
> not all platforms reset mpic at kernel start-up. For example,
> kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called.
>
> Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]>
> ---
Would be interesting to find out why it hangs tho... it shouldn't .
Ben.
> arch/powerpc/sysdev/mpic.c | 6 +-----
> 1 files changed, 1 insertion(+), 5 deletions(-)
>
> --- powerpc/arch/powerpc/sysdev/mpic.c 2008-02-26 15:56:57.000000000
> +0300
> +++ linux-2.6.new/arch/powerpc/sysdev/mpic.c 2008-04-03 23:00:45.000000000
> +0400
> @@ -1410,11 +1410,6 @@ void mpic_cpu_set_priority(int prio)
> mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), prio);
> }
>
> -/*
> - * XXX: someone who knows mpic should check this.
> - * do we need to eoi the ipi including for kexec cpu here (see xics
> comments)?
> - * or can we reset the mpic in the new kernel?
> - */
> void mpic_teardown_this_cpu(int secondary)
> {
> struct mpic *mpic = mpic_primary;
> @@ -1434,6 +1429,7 @@ void mpic_teardown_this_cpu(int secondar
>
> /* Set current processor priority to max */
> mpic_cpu_write(MPIC_INFO(CPU_CURRENT_TASK_PRI), 0xf);
> + mpic_eoi(mpic);
>
> spin_unlock_irqrestore(&mpic_lock, flags);
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
