Stephen Rothwell <s...@canb.auug.org.au> writes: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this statement may fall through > [-Wimplicit-fallthrough=] > cmd->info.devaddr &= 0xfe; > ~~~~~~~~~~~~~~~~~~^~~~~~~ > drivers/macintosh/smu.c:855:2: note: here > case SMU_I2C_TRANSFER_STDSUB: > ^~~~ > > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Gustavo A. R. Silva <gust...@embeddedor.com> > Cc: Kees Cook <keesc...@chromium.org> > Signed-off-by: Stephen Rothwell <s...@canb.auug.org.au> > --- > drivers/macintosh/smu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c > index 276065c888bc..23f1f41c8602 100644 > --- a/drivers/macintosh/smu.c > +++ b/drivers/macintosh/smu.c > @@ -852,6 +852,7 @@ int smu_queue_i2c(struct smu_i2c_cmd *cmd) > break; > case SMU_I2C_TRANSFER_COMBINED: > cmd->info.devaddr &= 0xfe; > + /* fall through */ > case SMU_I2C_TRANSFER_STDSUB: > if (cmd->info.sublen > 3) > return -EINVAL;
Why do we think it's an expected fall through? I can't really convince myself from the surrounding code that it's definitely intentional. cheers
