Re: [PATCH] powerpc/kvm: Fall through switch case explicitly

[Stephen Rothwell]

Hi Santosh,

On Mon, 29 Jul 2019 11:25:36 +0530 Santosh Sivaraj <sant...@fossix.org> wrote:
>
> Implicit fallthrough warning was enabled globally which broke
> the build. Make it explicit with a `fall through` comment.
> 
> Signed-off-by: Santosh Sivaraj <sant...@fossix.org>
> ---
>  arch/powerpc/kvm/book3s_32_mmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/kvm/book3s_32_mmu.c 
> b/arch/powerpc/kvm/book3s_32_mmu.c
> index 653936177857..18f244aad7aa 100644
> --- a/arch/powerpc/kvm/book3s_32_mmu.c
> +++ b/arch/powerpc/kvm/book3s_32_mmu.c
> @@ -239,6 +239,7 @@ static int kvmppc_mmu_book3s_32_xlate_pte(struct kvm_vcpu 
> *vcpu, gva_t eaddr,
>                               case 2:
>                               case 6:
>                                       pte->may_write = true;
> +                                     /* fall through */
>                               case 3:
>                               case 5:
>                               case 7:
> -- 
> 2.20.1
> 

Thanks

Reviewed-by: Stephen Rothwell <s...@canb.auug.org.au>

This only shows up as a warning in a powerpc allyesconfig build.
-- 
Cheers,
Stephen Rothwell

pgpbXnSZyNvg8.pgp
Description: OpenPGP digital signature