On Sun, 2019-07-28 at 18:01 +0200, Valentin Longchamp wrote: > Hi Scott, Kumar, > > Looking at this patch I have realised that I had already submitted it > to the mailing list nearly 2 years ago: > https://patchwork.ozlabs.org/patch/842944/ > > Could you please make sure that this one gets merged in the next > window, so that I avoid forgetting such a patch a 2nd time ? > > Thanks a lot
I added it to my patchwork todo list; thanks for the reminder. > Le dim. 14 juil. 2019 à 22:05, Valentin Longchamp > <[email protected]> a écrit : > > > > Change all phy-connection-type properties to phy-mode that are better > > supported by the fman driver. > > > > Use the more readable fixed-link node for the 2 sgmii links. > > > > Change the RGMII link to rgmii-id as the clock delays are added by the > > phy. > > > > Signed-off-by: Valentin Longchamp <[email protected]> I don't see any other uses of phy-mode in arch/powerpc/boot/dts/fsl, and I see lots of phy-connection-type with fman. Madalin, does this patch look OK? -Scott > > --- > > arch/powerpc/boot/dts/fsl/kmcent2.dts | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/fsl/kmcent2.dts > > b/arch/powerpc/boot/dts/fsl/kmcent2.dts > > index 48b7f9797124..c3e0741cafb1 100644 > > --- a/arch/powerpc/boot/dts/fsl/kmcent2.dts > > +++ b/arch/powerpc/boot/dts/fsl/kmcent2.dts > > @@ -210,13 +210,19 @@ > > > > fman@400000 { > > ethernet@e0000 { > > - fixed-link = <0 1 1000 0 0>; > > - phy-connection-type = "sgmii"; > > + phy-mode = "sgmii"; > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + }; > > }; > > > > ethernet@e2000 { > > - fixed-link = <1 1 1000 0 0>; > > - phy-connection-type = "sgmii"; > > + phy-mode = "sgmii"; > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + }; > > }; > > > > ethernet@e4000 { > > @@ -229,7 +235,7 @@ > > > > ethernet@e8000 { > > phy-handle = <&front_phy>; > > - phy-connection-type = "rgmii"; > > + phy-mode = "rgmii-id"; > > }; > > > > mdio0: mdio@fc000 { > > -- > > 2.17.1 > > > >
