On Mon, Jul 15, 2019 at 06:33:00PM +1000, Alexey Kardashevskiy wrote: > > > On 13/07/2019 01:20, Christoph Hellwig wrote: > > > This skips the 32bit DMA setup check if the bypass is can be selected. > > > > That sentence does not parse. I think you need to dop the "can be" > > based on the actual patch. > > > "the 32bit DMA setup check" is > "if (!(tbl = get_iommu_table_base(dev)))". > > I can rephrase though.
What I mean is to replace "This skips the 32bit DMA setup check if the bypass is can be selected." with "This skips the 32bit DMA setup check if the bypass is selected." or alternatively: "This skips the 32bit DMA setup check if the bypass can be selected." but I think the first version is more accurate.
