On Wed, 02 Apr 2008 18:52:10 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > +++ linux-work/arch/powerpc/kernel/stacktrace.c 2008-04-02 > 16:46:07.000000000 +1100 > @@ -0,0 +1,52 @@ > +
Copyight and license statement needed.
> +#include <linux/sched.h>
> +#include <linux/stacktrace.h>
You should include <asm/ptrace.h> for STACK_FRAME_OVERHEAD and struct pt_regs.
> +#ifdef CONFIG_PPC64
> +#define MIN_STACK_FRAME 112 /* same as STACK_FRAME_OVERHEAD, in fact */
So use STACK_FRAME_OVERHEAD?
> +#define FRAME_LR_SAVE 2
> +#define INT_FRAME_SIZE (sizeof(struct pt_regs) + STACK_FRAME_OVERHEAD + 288)
^^^^^^^^^^^^^^^^^^^^
Its used here already ...
> +#define REGS_MARKER 0x7265677368657265ul
Maybe we need to put REGS_MARKER into a header file as it already appears
in two assembly files and two C files.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpvIHwYN4pQ0.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
