Nathan Lynch <nath...@linux.ibm.com> writes:
> Hi Michael,
>
> Nathan Lynch <nath...@linux.ibm.com> writes:
>> The protocol for suspending or migrating an LPAR requires all present
>> processor threads to enter H_JOIN. So if we have threads offline, we
>> have to temporarily bring them up. This can race with administrator
>> actions such as SMT state changes. As of dfd718a2ed1f ("powerpc/rtas:
>> Fix a potential race between CPU-Offline & Migration"),
>
> snowpatch/checkpatch flagged an error in my commit message here:
>
> ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit
> <12+ chars of sha1> ("<title line>")' - ie: 'commit dfd718a2ed1f
> ("powerpc/rtas: Fix a potential race between CPU-Offline &
> Migration")'
>
> I see this is in your next-test branch though. Should I fix the commit
> message and resend?
No that's fine.
You have a Fixes tag which is formatted correctly and that's what
matters IMO.
Ideally we could control that check to not complain about it being split
across lines when there's a fixes tag as well.
cheers
