On 6/18/19 11:45 AM, Michael Neuling wrote: > On Tue, 2019-06-18 at 09:57 +0530, Ravi Bangoria wrote: >> Directly setting dawr and dawrx with 0 should be enough to >> disable watchpoint. No need to reset individual bits in >> variable and then set in hw. > > This seems like a pointless optimisation to me. > > I'm all for adding more code/complexity if it buys us some performance, but I > can't imagine this is a fast path (nor have you stated any performance > benefits). This gets called from sched_switch. I expected the improvement when we switch from monitored process to non-monitored process. With such scenario, I tried to measure the difference in execution time of set_dawr but I don't see any improvement. So I'll drop the patch.
- Re: [PATCH 1/5] Powerpc/hw-breakpoint: Replace stale... Christophe Leroy
- [PATCH 2/5] Powerpc/hw-breakpoint: Refactor hw_breakpoint... Ravi Bangoria
- Re: [PATCH 2/5] Powerpc/hw-breakpoint: Refactor hw_b... Christophe Leroy
- Re: [PATCH 2/5] Powerpc/hw-breakpoint: Refactor ... Ravi Bangoria
- [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr() Ravi Bangoria
- Re: [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_... Michael Neuling
- Re: [PATCH 3/5] Powerpc/hw-breakpoint: Refactor ... Ravi Bangoria
- Re: [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_... Christophe Leroy
- [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path Ravi Bangoria
- Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disa... Michael Neuling
- Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize ... Ravi Bangoria
- Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disa... Christophe Leroy
- Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize ... Ravi Bangoria
- [PATCH 5/5] Powerpc/Watchpoint: Fix length calculation fo... Ravi Bangoria
- Re: [PATCH 5/5] Powerpc/Watchpoint: Fix length calcu... Christophe Leroy
- Re: [PATCH 5/5] Powerpc/Watchpoint: Fix length c... Ravi Bangoria
- Re: [PATCH 5/5] Powerpc/Watchpoint: Fix length calcu... Michael Neuling
- Re: [PATCH 5/5] Powerpc/Watchpoint: Fix length c... Ravi Bangoria
- Re: [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Code re... Christophe Leroy
- Re: [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plus Co... Michael Neuling
- Re: [PATCH 0/5] Powerpc/hw-breakpoint: Fixes plu... Ravi Bangoria