Re: [PATCH] powerpc/mm/32s: fix condition that is always true

[Christophe Leroy]

Le 17/06/2019 à 23:22, Andreas Schwab a écrit :

Move a misplaced paren that makes the condition always true.

Fixes: 63b2bc619565 ("powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX")
Signed-off-by: Andreas Schwab <sch...@linux-m68k.org>

Reviewed-by: Christophe Leroy <christophe.le...@c-s.fr>

---
  arch/powerpc/mm/pgtable_32.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c
index d53188dee18f..35cb96cfc258 100644
--- a/arch/powerpc/mm/pgtable_32.c
+++ b/arch/powerpc/mm/pgtable_32.c
@@ -360,7 +360,7 @@ void mark_initmem_nx(void)
        unsigned long numpages = PFN_UP((unsigned long)_einittext) -
                                 PFN_DOWN((unsigned long)_sinittext);

- if (v_block_mapped((unsigned long)_stext) + 1)

+       if (v_block_mapped((unsigned long)_stext + 1))
                mmu_mark_initmem_nx();
        else
                change_page_attr(page, numpages, PAGE_KERNEL);