Re: [PATCH] powerpc: Remove double free

[Christophe Leroy]

kobject_put() released index_dir->kobj

but who will release 'index' ?

Christophe

Le 15/05/2019 à 11:07, Tobin C. Harding a écrit :

kfree() after kobject_put().  Who ever wrote this was on crack.

Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak")
Signed-off-by: Tobin C. Harding <to...@kernel.org>
---

FTR

git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80
7e8039795a80    Tobin C. Harding        Tue Apr 30 11:09:23 2019 +1000  
powerpc/cacheinfo: Fix kobject memleak

  arch/powerpc/kernel/cacheinfo.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c
index f2ed3ef4b129..862e2890bd3d 100644
--- a/arch/powerpc/kernel/cacheinfo.c
+++ b/arch/powerpc/kernel/cacheinfo.c
@@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, 
int index,
                                  cache_dir->kobj, "index%d", index);
        if (rc) {
                kobject_put(&index_dir->kobj);
-               kfree(index_dir);
                return;
        }